dbusService: Don't double-wrap remote errors

Returning a GLib.Error from a method invocation will encode the
error when sent over the wire. In case the error itself is already
an encoded remote error, just passing it on will result in double
wrapping.

Avoid that by stripping any remote error information before
returning it.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3159>

diff --git a/js/dbusServices/dbusService.js b/js/dbusServices/dbusService.js
index 422ef60e24c2ed911475bb5349f3d2cd1082812a..ab7af9291bc3fb7f8a8149b6058752570edb834d 100644 (file)
--- a/js/dbusServices/dbusService.js
+++ b/js/dbusServices/dbusService.js
@@ -75,6 +75,7 @@ export class ServiceImplementation {
             return false;
 
         if (error instanceof GLib.Error) {
+            Gio.DBusError.strip_remote_error(error);
             invocation.return_gerror(error);
         } else {
             let name = error.name;